From 2128001171ba924d6b5a08900c1c5136762123da Mon Sep 17 00:00:00 2001 From: Brandon Bergren Date: Sun, 3 Nov 2019 02:18:45 +0000 Subject: [PATCH] powerpc: Add display of raw instruction values to x/I in ddb. The "alternate format" character 'I' previously had the same behavior as the "display as an instruction" character 'i'. With this change, it will now prefix each disassembled instruction with the raw hex value. As PowerPC instructions are always 32 bits and always aligned, and there are no alternate modes that would affect instruction decoding or display, this seemed to me to be the obvious interpretation of "alternate format". Approved by: jhibbits (mentor) Differential Revision: https://reviews.freebsd.org/D22223 --- sys/powerpc/powerpc/db_disasm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/powerpc/powerpc/db_disasm.c b/sys/powerpc/powerpc/db_disasm.c index 66f04d918355..08764ce6bda8 100644 --- a/sys/powerpc/powerpc/db_disasm.c +++ b/sys/powerpc/powerpc/db_disasm.c @@ -1073,6 +1073,8 @@ db_disasm(db_addr_t loc, bool extended) int class; instr_t opcode; opcode = *(instr_t *)(loc); + if (extended) + db_printf("|%08x| ", opcode); class = opcode >> 26; (opcodes_base[class])(opcode, loc);