powerpc: Add display of raw instruction values to x/I in ddb.

The "alternate format" character 'I' previously had the same behavior as
the "display as an instruction" character 'i'. With this change, it will now
prefix each disassembled instruction with the raw hex value.

As PowerPC instructions are always 32 bits and always aligned, and there are
no alternate modes that would affect instruction decoding or display, this
seemed to me to be the obvious interpretation of "alternate format".

Approved by: jhibbits (mentor)
Differential Revision: https://reviews.freebsd.org/D22223
This commit is contained in:
Brandon Bergren 2019-11-03 02:18:45 +00:00
parent 2276d9024d
commit 2128001171
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=354272

View File

@ -1073,6 +1073,8 @@ db_disasm(db_addr_t loc, bool extended)
int class; int class;
instr_t opcode; instr_t opcode;
opcode = *(instr_t *)(loc); opcode = *(instr_t *)(loc);
if (extended)
db_printf("|%08x| ", opcode);
class = opcode >> 26; class = opcode >> 26;
(opcodes_base[class])(opcode, loc); (opcodes_base[class])(opcode, loc);