hardenedbsd/HardenedBSD
1
0
Fork 0
mirror of https://git.hardenedbsd.org/hardenedbsd/HardenedBSD.git synced 2024-11-29 12:44:53 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Workaround for the setlogin()-in-same-session-as-inetd bug.

Browse Source 
This causes:
1: inetd to clear it's getlogin() name at startup (in case the sysadmin
	logged in and su'ed to root and restarted inetd)
2: inetd to start each spawned process in it's own session.
3: inetd to call setlogin() on non-root processes (eg: uucp for uucico)
4: log failures more extensively

This means that root spawned processes from inetd remain responsible for
setting their login name if they change their uid. (eg: rshd, login, etc).

If they do not do so, it is safer for them to have no "login name" than a
wrong one (like "root") because the getlogin() system call is documented
as "secure" on 4.4BSD.  inetd when started from /etc/rc would have no login
name anyway, so this isn't really a change - it's making it consistant with
the bootup state...

The setsid() change *may* cause something to break that is doing a setsid()
itself and checking the result - it will fail now because it's already been
done.  The consensis seems to be that this is unlikely. David G. thinks
this is acceptable as it is cleaner from an architectural point of view.
This commit is contained in:
peter 1995-11-03 09:30:13 +00:00
parent 5218fe027c
commit 40d1117791
1 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
usr.sbin/inetd/inetd.c
View File

@ -40,7 +40,7 @@ static char copyright[] =
#ifndef lint
/* from: @(#)inetd.c 8.4 (Berkeley) 4/13/94"; */
static char inetd_c_rcsid[] =
"$Id: inetd.c,v 1.7 1995/10/12 16:43:26 wollman Exp $";
"$Id: inetd.c,v 1.8 1995/10/30 14:03:00 adam Exp $";
#endif /* not lint */
/*
@ -297,7 +297,18 @@ main(argc, argv, envp)
CONFIG = argv[0];
if (debug == 0) {
FILE *fp;
daemon(0, 0);
if (daemon(0, 0) < 0) {
syslog(LOG_WARNING, "daemon(0,0) failed: %m");
}
/*
* In case somebody has started inetd manually, we need to
* clear the logname, so that old servers run as root do not
* get the user's logname..
*/
if (setlogin("") < 0) {
syslog(LOG_WARNING, "cannot clear logname: %m");
/* no big deal if it fails.. */
}
pid = getpid();
fp = fopen(_PATH_INETDPID, "w");
if (fp) {
@ -440,8 +451,6 @@ main(argc, argv, envp)
}
sigsetmask(0L);
if (pid == 0) {
if (debug && dofork)
setsid();
if (dofork) {
if (debug)
fprintf(stderr, "+ Closing from %d\n",
@ -469,7 +478,19 @@ main(argc, argv, envp)
recv(0, buf, sizeof (buf), 0);
_exit(1);
}
if (setsid() < 0) {
syslog(LOG_ERR,
"%s: can't setsid(): %m",
sep->se_service);
/* _exit(1); not fatal yet */
}
if (pwd->pw_uid) {
if (setlogin(sep->se_user) < 0) {
syslog(LOG_ERR,
"%s: can't setlogin(%s): %m",
sep->se_service, sep->se_user);
/* _exit(1); not fatal yet */
}
if (setgid(pwd->pw_gid) < 0) {
syslog(LOG_ERR,
"%s: can't set gid %d: %m",