hardenedbsd/HardenedBSD
1
0
Fork 0
mirror of https://git.hardenedbsd.org/hardenedbsd/HardenedBSD.git synced 2025-01-22 16:44:32 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

- Don't forget about NDFREE() in case of vn_open() failure.

Browse Source 
- Don't forget about vn_close() in case of failure.
This commit is contained in:
Pawel Jakub Dawidek 2004-09-14 18:43:24 +00:00
parent 31580e6817
commit 52c6716fee
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=135241
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/dev/md/md.c
View File

@ -897,10 +897,10 @@ mdcreate_vnode(struct md_ioctl *mdio, struct thread *td)
flags &= ~FWRITE;
NDINIT(&nd, LOOKUP, FOLLOW, UIO_USERSPACE, mdio->md_file, td);
error = vn_open(&nd, &flags, 0, -1);
if (error)
return (error);
}
NDFREE(&nd, NDF_ONLY_PNBUF);
if (error)
return (error);
if (nd.ni_vp->v_type != VREG ||
(error = VOP_GETATTR(nd.ni_vp, &vattr, td->td_ucred, td))) {
VOP_UNLOCK(nd.ni_vp, 0, td);
@ -939,11 +939,13 @@ mdcreate_vnode(struct md_ioctl *mdio, struct thread *td)
else
sc->nsect = vattr.va_size / sc->secsize; /* XXX: round up ? */
if (sc->nsect == 0) {
(void) vn_close(nd.ni_vp, flags, td->td_ucred, td);
mddestroy(sc, td);
return (EINVAL);
}
error = mdsetcred(sc, td->td_ucred);
if (error) {
(void) vn_close(nd.ni_vp, flags, td->td_ucred, td);
mddestroy(sc, td);
return (error);
}