hardenedbsd/HardenedBSD
1
0
Fork 0
mirror of https://git.hardenedbsd.org/hardenedbsd/HardenedBSD.git synced 2024-11-21 18:50:50 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

ping tests: Run tests unprivileged inside a vnet

Browse Source 
In order to create vnet jails, atf_python needs root privileges.
However, once the vnet is created, its privileges inside the vnet can be
demoted, as these tests should not require root in order to pass.

Reviewed by:	markj
Approved by:	emaste (mentor)
Fixes:	4efaf43c6f ("ping: Require root user for pytests")
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D42175
This commit is contained in:
Jose Luis Duran 2024-11-05 03:00:38 +00:00
parent 8b13cb9d65
commit 5797a03fe8
No known key found for this signature in database
GPG Key ID: 5415E244477475CC
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sbin/ping/tests/test_ping.py
View File

@ -724,6 +724,7 @@ PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2
@pytest.mark.parametrize("expected", testdata) @pytest.mark.parametrize("expected", testdata)
@pytest.mark.require_user("root") @pytest.mark.require_user("root")
@pytest.mark.require_user("unprivileged")
def test_ping(self, expected): def test_ping(self, expected):
"""Test ping""" """Test ping"""
ping = subprocess.run( ping = subprocess.run(
@ -753,6 +754,7 @@ PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2
@pytest.mark.parametrize("expected", ping46_testdata) @pytest.mark.parametrize("expected", ping46_testdata)
@pytest.mark.require_user("root") @pytest.mark.require_user("root")
@pytest.mark.require_user("unprivileged")
def test_ping_46(self, expected): def test_ping_46(self, expected):
"""Test ping -4/ping -6""" """Test ping -4/ping -6"""
for version in [4, 6]: for version in [4, 6]: