hardenedbsd/HardenedBSD
1
0
Fork 0
mirror of https://git.hardenedbsd.org/hardenedbsd/HardenedBSD.git synced 2025-01-01 00:18:15 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Call output process in slstart() whether or not there is any output. As

Browse Source 
in pppstart(), the output process may be overloaded to handle hardware
flow control and hardware output completions.

Don't wait for output to drain in slclose().  Discard output immediately.
New output is not prevented while processes are waiting for output to
drain (this is a bug), so the wait was sometimes forever.  Infinite
waits are also possible when CCTS_OFLOW is enabled and CTS is down.
Infinite waits were also caused by the above bug in slstart().

Start changing new init stuff yet again: rename unused arg `dummy'.

Reviewed by:	davidg
This commit is contained in:
Bruce Evans 1995-09-10 12:22:59 +00:00
parent e7c89b42c5
commit 6b435e575c
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
sys/net/if_sl.c
View File

@ -31,7 +31,7 @@
* SUCH DAMAGE.
*
* @(#)if_sl.c 8.6 (Berkeley) 2/1/94
* $Id: if_sl.c,v 1.29 1995/08/30 00:33:20 bde Exp $
* $Id: if_sl.c,v 1.30 1995/09/09 18:10:24 davidg Exp $
*/
/*
@ -199,8 +199,8 @@ static struct linesw slipdisc =
* Called from boot code to establish sl interfaces.
*/
static void
slattach(udata)
void *udata;
slattach(dummy)
void *dummy;
{
register struct sl_softc *sc;
register int i = 0;
@ -315,8 +315,7 @@ slclose(tp,flag)
register struct sl_softc *sc;
int s;
if (ttywflush(tp))
ttyflush(tp, FREAD | FWRITE);
ttyflush(tp, FREAD | FWRITE);
/*
* XXX the placement of the following spl is misleading. tty
* interrupts must be blocked across line discipline switches
@ -496,17 +495,19 @@ slstart(tp)
for (;;) {
/*
* If there is more in the output queue, just send it now.
* We are being called in lieu of ttstart and must do what
* it would.
* Call output process whether or not there is more in the
* output queue. We are being called in lieu of ttstart
* and must do what it would.
*/
(*tp->t_oproc)(tp);
if (tp->t_outq.c_cc != 0) {
if (sc != NULL)
sc->sc_flags &= ~SC_OUTWAIT;
(*tp->t_oproc)(tp);
if (tp->t_outq.c_cc > SLIP_HIWAT)
return 0;
}
/*
* This happens briefly when the line shuts down.
*/