From 85011246ac4fcbcae797520a892bf31c5af463b9 Mon Sep 17 00:00:00 2001 From: Gleb Smirnoff Date: Tue, 27 Jul 2010 10:05:27 +0000 Subject: [PATCH] When installing a new ARP entry via 'arp -S', lla_lookup() will either find an existing entry, or allocate a new one. In the latter case an entry would have flags, that were supplied as argument to lla_lookup(). In case of an existing entry, flags aren't modified. This lead to losing LLE_PUB and/or LLE_PROXY flags. We should apply these flags either in lla_rt_output() or in the in.c:in_lltable_lookup(). It seems to me that lla_rt_output() is a more correct choice. PR: kern/148784, kern/146539 Silence from: qingli, 5 days --- sys/net/if_llatbl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/net/if_llatbl.c b/sys/net/if_llatbl.c index 8e193c15e4cf..3af9effd9f1a 100644 --- a/sys/net/if_llatbl.c +++ b/sys/net/if_llatbl.c @@ -337,6 +337,7 @@ lla_rt_output(struct rt_msghdr *rtm, struct rt_addrinfo *info) * LLE_DELETED flag, and reset the expiration timer */ bcopy(LLADDR(dl), &lle->ll_addr, ifp->if_addrlen); + lle->la_flags |= (flags & (LLE_PUB | LLE_PROXY)); lle->la_flags |= LLE_VALID; lle->la_flags &= ~LLE_DELETED; #ifdef INET6