hardenedbsd/HardenedBSD
1
0
Fork 0
mirror of https://git.hardenedbsd.org/hardenedbsd/HardenedBSD.git synced 2024-11-23 06:41:08 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

random(6): Fix off-by-one

Browse Source 
After r355693, random(6) -f sometimes fail to output all the lines of the
input file.  This is because the range from which random indices are chosen
is too big, so occasionally the random selection doesn't correspond to any
line and nothing gets printed.

(Ed. note: Mea culpa.  Working on r355693, I was confused by the sometime
use of 1-indexing, sometimes 0-indexing in randomize_fd().)

Submitted by:	Ryan Moeller <ryan AT freqlabs.com>
X-MFC-With:	r355693
Sponsored by:	iXsystems, Inc.
Differential Revision:	https://reviews.freebsd.org/D23199
This commit is contained in:
Conrad Meyer 2020-01-16 21:38:44 +00:00
parent 1137d1a7e5
commit 92f7ba208c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=356810
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
usr.bin/random/randomize_fd.c
View File

@ -211,7 +211,7 @@ make_token:
free(buf);
for (i = numnode; i > 0; i--) {
selected = arc4random_uniform(numnode + 1);
selected = arc4random_uniform(numnode);
for (j = 0, prev = n = rand_root; n != NULL; j++, prev = n, n = n->next) {
if (j == selected) {