hardenedbsd/HardenedBSD
1
0
Fork 0
mirror of https://git.hardenedbsd.org/hardenedbsd/HardenedBSD.git synced 2024-12-22 17:24:23 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Zeroing memset() in opiechallenge() really is not needed because it is the

Browse Source 
very first thing immediately following opielookup() does being entered, i.e.
look at this:

int opielookup FUNCTION((opie, principal), struct opie *opie AND char
*principal
)
{
  int i;

  memset(opie, 0, sizeof(struct opie));
...
This commit is contained in:
Andrey A. Chernov 2002-01-24 22:19:21 +00:00
parent 9118ec5a27
commit 9df24552a0
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=89766
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
contrib/opie/libopie/challenge.c
View File

@ -20,6 +20,9 @@ License Agreement applies to this software.
syslog. Add sha plumbing. syslog. Add sha plumbing.
Modified by cmetz for OPIE 2.2. Use FUNCTION declaration et al. Modified by cmetz for OPIE 2.2. Use FUNCTION declaration et al.
Created at NRL for OPIE 2.2 from opiesubr2.c Created at NRL for OPIE 2.2 from opiesubr2.c
$FreeBSD$
*/ */
#include "opie_cfg.h" #include "opie_cfg.h"
#include <stdio.h> #include <stdio.h>
@ -52,8 +55,6 @@ int opiechallenge FUNCTION((mp, name, ss), struct opie *mp AND char *name AND ch
{ {
int rval = -1; int rval = -1;
memset(mp, 0, sizeof(*mp));
rval = opielookup(mp, name); rval = opielookup(mp, name);
#if DEBUG #if DEBUG
if (rval) syslog(LOG_DEBUG, "opiechallenge: opielookup(mp, name=%s) returned %d", name, rval); if (rval) syslog(LOG_DEBUG, "opiechallenge: opielookup(mp, name=%s) returned %d", name, rval);