hardenedbsd/HardenedBSD
1
0
Fork 0
mirror of https://git.hardenedbsd.org/hardenedbsd/HardenedBSD.git synced 2024-12-28 22:36:24 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid clobbering the gecos field, as we intend to use the original later.

Browse Source 
PR:		bin/50563
This commit is contained in:
Dag-Erling Smørgrav 2003-04-09 18:18:42 +00:00
parent 9c9265929b
commit a4280091c3
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=113304
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
usr.bin/chpass/edit.c
View File

@ -109,7 +109,7 @@ static int
display(const char *tfn, struct passwd *pw)
{
FILE *fp;
char *bp, *p;
char *bp, *gecos, *p;
if ((fp = fopen(tfn, "w")) == NULL) {
warn("%s", tfn);
@ -151,8 +151,13 @@ display(const char *tfn, struct passwd *pw)
(void)fprintf(fp, "Shell: %s\n",
*pw->pw_shell ? pw->pw_shell : _PATH_BSHELL);
else
list[E_SHELL].restricted = 1;
bp = pw->pw_gecos;
list[E_SHELL].restricted = 1;
if ((bp = gecos = strdup(pw->pw_gecos)) == NULL) {
warn(NULL);
fclose(fp);
return (-1);
}
p = strsep(&bp, ",");
p = strdup(p ? p : "");
@ -183,6 +188,8 @@ display(const char *tfn, struct passwd *pw)
if (!list[E_OTHER].restricted || master_mode)
(void)fprintf(fp, "Other information: %s\n", bp);
free(gecos);
(void)fchown(fileno(fp), getuid(), getgid());
(void)fclose(fp);
return (0);