hardenedbsd/HardenedBSD
1
0
Fork 0
mirror of https://git.hardenedbsd.org/hardenedbsd/HardenedBSD.git synced 2024-11-22 20:11:06 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

posixshm largepage_mmap: fix a racy test

Browse Source 
You can't ever safely map a single page and then map a superpage sized
mapping over it with MAP_FIXED.  Even in a single-threaded program, ASLR
might mean you land too close to another mapping and on CheriBSD we
don't allow the initial reservation to grow because doing so requires
program changes that are hard to automate.

To avoid this, map the entire region we want to use upfront.

Reviewed by:	markj
Obtained from:	CheriBSD
Sponsored by:	DARPA
Differential Revision:	https://reviews.freebsd.org/D43282
This commit is contained in:
Brooks Davis 2024-01-03 16:39:53 +00:00
parent 85c9d36497
commit a9174861ea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/sys/posixshm/posixshm_test.c
View File

@ -1407,7 +1407,7 @@ ATF_TC_BODY(largepage_mmap, tc)
ATF_REQUIRE(munmap(addr, ps[i] == 0)); ATF_REQUIRE(munmap(addr, ps[i] == 0));
/* Clobber an anonymous mapping with a superpage. */ /* Clobber an anonymous mapping with a superpage. */
addr1 = mmap(NULL, ps[0], PROT_READ | PROT_WRITE, addr1 = mmap(NULL, ps[i], PROT_READ | PROT_WRITE,
MAP_ANON | MAP_PRIVATE | MAP_ALIGNED(ffsl(ps[i]) - 1), -1, MAP_ANON | MAP_PRIVATE | MAP_ALIGNED(ffsl(ps[i]) - 1), -1,
0); 0);
ATF_REQUIRE_MSG(addr1 != MAP_FAILED, ATF_REQUIRE_MSG(addr1 != MAP_FAILED,