hardenedbsd/HardenedBSD
1
0
Fork 0
mirror of https://git.hardenedbsd.org/hardenedbsd/HardenedBSD.git synced 2024-11-22 03:04:34 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

devd: Improve devmatch support

Browse Source 
We know that calling devmatch will be futile if there's no plug and play
information for it to match on. Avoid this generically when we see
	"? at +on"
which happens only when the location and pnpinfo aren't provided. Don't
call "service devmatch quietstart" here.

We also ignore ACPI devices with a _HID of none. These also will never
load a new driver, so avoid calling "service devmatch quietstart" here too.

Use the more compatct "$*" instead of "'?'$_" when calling "service
devmatch quietstart" since it will evaluate to the same thing.

On my laptop, this eliminates 45% of the calls to devmatch. While it
would be even better to integrate devmatch into devd (so we only parse
linker.hints once), that will have to wait for another day as it's a bit
more complex to arrange that avoiding easy to avoid calls.

Sponsored by:		Netflix
Reviewed by:		emaste
Differential Revision:	https://reviews.freebsd.org/D42326
This commit is contained in:
Warner Losh 2023-10-27 15:23:47 -06:00
parent dbf203548b
commit aa7c028adb
1 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
sbin/devd/devmatch.conf
View File

@ -1,14 +1,32 @@
# # Implement the run-time component of devmatch by reacting to nomatch events.
#
# #
# Example devd configuration file for automatically # Ignore those devices that can't possibly match. When there's neither a
# loading what modules we can based on nomatch # location, nor a pnpinfo string, we know that there's nothing devmatch can
# events. # match on. When it's only a location, it'd debateable, but for nomatch
# events, we can't disambiguate between the two reliably.
#
nomatch 101 {
match "_" " +at +on .*";
};
#
# Ignore ACPI devices whose _HID is none. These cannot tell us what to load,
# since 'none' is not a valid id. There's no need to call devvmatch for these either.
#
nomatch 101 {
match "_HID" "none";
match "bus" "acpi[0-9]+";
};
# #
# Generic NOMATCH event # Generic NOMATCH event
#
# Note: It would be better to have some internal-to-devd action that will do
# what devmatch does without re-parsing loader.hints for each invocation
#
nomatch 100 { nomatch 100 {
action "service devmatch quietstart '?'$_"; action "service devmatch quietstart $*";
}; };
# Add the following to devd.conf to prevent this from running: # Add the following to devd.conf to prevent this from running: