HardenedBSD src tree
Go to file
Conrad Meyer 3693b18840 opencrypto: Loosen restriction on HMAC key sizes
Theoretically, HMACs do not actually have any limit on key sizes.
Transforms should compact input keys larger than the HMAC block size by
using the transform (hash) on the input key.

(Short input keys are padded out with zeros to the HMAC block size.)

Still, not all FreeBSD crypto drivers that provide HMAC functionality
handle longer-than-blocksize keys appropriately, so enforce a "maximum" key
length in the crypto API for auth_hashes that previously expressed a
requirement.  (The "maximum" is the size of a single HMAC block for the
given transform.)  Unconstrained auth_hashes are left as-is.

I believe the previous hardcoded sizes were committed in the original
import of opencrypto from OpenBSD and are due to specific protocol
details of IPSec.  Note that none of the previous sizes actually matched
the appropriate HMAC block size.

The previous hardcoded sizes made the SHA tests in cryptotest.py
useless for testing FreeBSD crypto drivers; none of the NIST-KAT example
inputs had keys sized to the previous expectations.

The following drivers were audited to check that they handled keys up to
the block size of the HMAC safely:

  Software HMAC:
    * padlock(4)
    * cesa
    * glxsb
    * safe(4)
    * ubsec(4)

  Hardware accelerated HMAC:
    * ccr(4)
    * hifn(4)
    * sec(4) (Only supports up to 64 byte keys despite claiming to
      support SHA2 HMACs, but validates input key sizes)
    * cryptocteon (MIPS)
    * nlmsec (MIPS)
    * rmisec (MIPS) (Amusingly, does not appear to use key material at
      all -- presumed broken)

Reviewed by:	jhb (previous version), rlibby (previous version)
Sponsored by:	Dell EMC Isilon
Differential Revision:	https://reviews.freebsd.org/D12437
2017-09-26 16:18:10 +00:00
bin
cddl MFV r323535: 8585 improve batching done in zil_commit() 2017-09-26 11:04:08 +00:00
contrib Fix the return value from _Unwind_Backtrace() on arm. 2017-09-25 23:50:10 +00:00
crypto
etc Do not actually install uneeded alias for man 2017-09-26 05:46:10 +00:00
gnu
include
kerberos5
lib capsicum_helpers: Add SEEK to default stdio rights set 2017-09-25 19:33:32 +00:00
libexec
release Revert r323812 from release/tools/arm.subr, which has broken the 2017-09-22 14:34:27 +00:00
rescue
sbin Continuing efforts to provide hardening of FFS, this change adds a 2017-09-22 12:45:15 +00:00
secure
share Add the ability to report and set debug flags as text strings instead of 2017-09-24 13:14:50 +00:00
sys opencrypto: Loosen restriction on HMAC key sizes 2017-09-26 16:18:10 +00:00
targets
tests crypto(9): Use a more specific error code when a capable driver is not found 2017-09-26 01:31:49 +00:00
tools Fix packages with interactive post install scripts. 2017-09-24 14:22:36 +00:00
usr.bin calendar: replace strcpy/strcat with asprintf 2017-09-26 11:16:33 +00:00
usr.sbin mountd: Avoid memory leak by freeing dp_dirp 2017-09-26 12:15:13 +00:00
.arcconfig
.arclint
COPYRIGHT
LOCKS
MAINTAINERS
Makefile
Makefile.inc1 Do not print error when running make delete-old on system 2017-09-26 05:33:15 +00:00
Makefile.libcompat
ObsoleteFiles.inc Remove empty lines for consistency with other entries 2017-09-26 05:47:33 +00:00
README
README.md
UPDATING

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

For copyright information, please see the file COPYRIGHT in this directory (additional copyright information also exists for some sources in this tree - please see the specific source directories for more information).

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7) and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html for more information, including setting make(1) variables.

The buildkernel and installkernel targets build and install the kernel and the modules (see below). Please see the top of the Makefile in this directory for more information on the standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process. See build(7), config(8), and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information.

Note: If you want to build and install the kernel with the buildkernel and installkernel targets, you might need to build world before. More information is available in the handbook.

The kernel configuration files reside in the sys/<arch>/conf sub-directory. GENERIC is the default configuration used in release builds. NOTES contains entries and documentation for all possible devices, not just those commonly used.

Source Roadmap:

bin				System/user commands.

cddl			Various commands and libraries under the Common Development  
				and Distribution License.

contrib			Packages contributed by 3rd parties.

crypto			Cryptography stuff (see crypto/README).

etc				Template files for /etc.

gnu				Various commands and libraries under the GNU Public License.  
				Please see gnu/COPYING* for more information.

include			System include files.

kerberos5		Kerberos5 (Heimdal) package.

lib				System libraries.

libexec			System daemons.

release			Release building Makefile & associated tools.

rescue			Build system for statically linked /rescue utilities.

sbin			System commands.

secure			Cryptographic libraries and commands.

share			Shared resources.

sys				Kernel sources.

tests			Regression tests which can be run by Kyua.  See tests/README
				for additional information.

tools			Utilities for regression testing and miscellaneous tasks.

usr.bin			User commands.

usr.sbin		System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html