HardenedBSD/usr.bin/fsync/fsync.c
Xin LI 39aa7c9d16 Correct some style nits that I have mistakenly submitted as
suggestions which result in the last revision[*]:
	- style(9) and sysexits(3) suggests that we use EX_*
	  as exit values, instead of some other values like
	  those returned from a system call as errno.

Additionally, follow Ruslan's suggestion about style(9) and
other style improvements:
	- Since open(2) says that it returns -1 on errors,
	  explicitly determine whether it is returning -1
	  rather than whether the return value is less than
	  zero.
	- Only set rval when there is no previous error.
	  This distinguishes the first error that occours.
	- Use exit() in favor of return in main(), this is
	  suggested in old style(9), while the evolve has
	  fade the suggestion.
	- Add some NOTREACHED comments.
	- Add blank line after first { because no local variables
	  in usage()

Thanks to Ruslan for his tireless explaining of the code standards
and knowledge of the history of style(9).

[*] Pointy hat to:	me

Submitted by:	ru (with some minor changes)
Discussed with:	ru, ssouhlal
2005-01-26 15:17:25 +00:00

81 lines
2.1 KiB
C

/*-
* Copyright (c) 2000 Paul Saab <ps@FreeBSD.org>
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
#ifndef lint
#endif /* not lint */
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
#include <err.h>
#include <fcntl.h>
#include <stdio.h>
#include <stdlib.h>
#include <sysexits.h>
#include <unistd.h>
static void usage(void);
int
main(int argc, char *argv[])
{
int fd;
int i;
int rval;
if (argc < 2) {
usage();
/* NOTREACHED */
}
rval = EX_OK;
for (i = 1; i < argc; ++i) {
if ((fd = open(argv[i], O_RDONLY)) == -1) {
warn("open %s", argv[i]);
if (rval == EX_OK)
rval = EX_NOINPUT;
continue;
}
if (fsync(fd) == -1) {
warn("fsync %s", argv[i]);
if (rval == EX_OK)
rval = EX_OSERR;
}
close(fd);
}
exit(rval);
/* NOTREACHED */
}
static void
usage(void)
{
fprintf(stderr, "usage: fsync file ...\n");
exit(EX_USAGE);
/* NOTREACHED */
}