mirror of
https://git.hardenedbsd.org/hardenedbsd/HardenedBSD.git
synced 2024-09-21 15:52:39 +02:00
491 lines
12 KiB
C
491 lines
12 KiB
C
#include "config.h"
|
|
|
|
#include "sntptest.h"
|
|
#include "networking.h"
|
|
#include "ntp_stdlib.h"
|
|
#include "unity.h"
|
|
|
|
#define CMAC "AES128CMAC"
|
|
#define CMAC_LENGTH 16
|
|
|
|
|
|
/* Hacks into the key database. */
|
|
extern struct key* key_ptr;
|
|
extern int key_cnt;
|
|
|
|
|
|
void PrepareAuthenticationTest(int key_id,int key_len,const char* type,const void* key_seq);
|
|
void PrepareAuthenticationTestMD5(int key_id,int key_len,const void* key_seq);
|
|
void setUp(void);
|
|
void tearDown(void);
|
|
void test_TooShortLength(void);
|
|
void test_LengthNotMultipleOfFour(void);
|
|
void test_TooShortExtensionFieldLength(void);
|
|
void test_UnauthenticatedPacketReject(void);
|
|
void test_CryptoNAKPacketReject(void);
|
|
void test_AuthenticatedPacketInvalid(void);
|
|
void test_AuthenticatedPacketUnknownKey(void);
|
|
void test_ServerVersionTooOld(void);
|
|
void test_ServerVersionTooNew(void);
|
|
void test_NonWantedMode(void);
|
|
void test_KoDRate(void);
|
|
void test_KoDDeny(void);
|
|
void test_RejectUnsyncedServer(void);
|
|
void test_RejectWrongResponseServerMode(void);
|
|
void test_AcceptNoSentPacketBroadcastMode(void);
|
|
void test_CorrectUnauthenticatedPacket(void);
|
|
void test_CorrectAuthenticatedPacketMD5(void);
|
|
void test_CorrectAuthenticatedPacketSHA1(void);
|
|
void test_CorrectAuthenticatedPacketCMAC(void);
|
|
|
|
/* [Bug 2998] There are some issues whith the definition of 'struct pkt'
|
|
* when AUTOKEY is undefined -- the formal struct is too small to hold
|
|
* all the extension fields that are going to be tested. We have to make
|
|
* sure we have the extra bytes, or the test yield undefined results due
|
|
* to buffer overrun.
|
|
*/
|
|
#ifndef AUTOKEY
|
|
# define EXTRA_BUFSIZE 256
|
|
#else
|
|
# define EXTRA_BUFSIZE 0
|
|
#endif
|
|
|
|
union tpkt {
|
|
struct pkt p;
|
|
u_char b[sizeof(struct pkt) + EXTRA_BUFSIZE];
|
|
};
|
|
|
|
static union tpkt testpkt;
|
|
static union tpkt testspkt;
|
|
static sockaddr_u testsock;
|
|
bool restoreKeyDb;
|
|
|
|
|
|
void
|
|
PrepareAuthenticationTest(
|
|
int key_id,
|
|
int key_len,
|
|
const char * type,
|
|
const void * key_seq
|
|
)
|
|
{
|
|
char str[25];
|
|
snprintf(str, 25, "%d", key_id);
|
|
ActivateOption("-a", str);
|
|
|
|
key_cnt = 1;
|
|
key_ptr = emalloc(sizeof(struct key));
|
|
key_ptr->next = NULL;
|
|
key_ptr->key_id = key_id;
|
|
key_ptr->key_len = key_len;
|
|
memcpy(key_ptr->typen, type, strlen(type) + 1);
|
|
|
|
TEST_ASSERT_TRUE(key_len < sizeof(key_ptr->key_seq));
|
|
|
|
memcpy(key_ptr->key_seq, key_seq, key_ptr->key_len);
|
|
restoreKeyDb = true;
|
|
}
|
|
|
|
|
|
void
|
|
PrepareAuthenticationTestMD5(
|
|
int key_id,
|
|
int key_len,
|
|
const void * key_seq
|
|
)
|
|
{
|
|
PrepareAuthenticationTest(key_id, key_len, "MD5", key_seq);
|
|
}
|
|
|
|
|
|
void
|
|
setUp(void)
|
|
{
|
|
|
|
sntptest();
|
|
restoreKeyDb = false;
|
|
|
|
/* Initialize the test packet and socket,
|
|
* so they contain at least some valid data.
|
|
*/
|
|
testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING, NTP_VERSION,
|
|
MODE_SERVER);
|
|
testpkt.p.stratum = STRATUM_REFCLOCK;
|
|
memcpy(&testpkt.p.refid, "GPS\0", 4);
|
|
|
|
/* Set the origin timestamp of the received packet to the
|
|
* same value as the transmit timestamp of the sent packet.
|
|
*/
|
|
l_fp tmp;
|
|
tmp.l_ui = 1000UL;
|
|
tmp.l_uf = 0UL;
|
|
|
|
HTONL_FP(&tmp, &testpkt.p.org);
|
|
HTONL_FP(&tmp, &testspkt.p.xmt);
|
|
}
|
|
|
|
|
|
void
|
|
tearDown(void)
|
|
{
|
|
if (restoreKeyDb) {
|
|
key_cnt = 0;
|
|
free(key_ptr);
|
|
key_ptr = NULL;
|
|
}
|
|
|
|
sntptest_destroy(); /* only on the final test!! if counter == 0 etc... */
|
|
}
|
|
|
|
|
|
void
|
|
test_TooShortLength(void)
|
|
{
|
|
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC - 1,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC - 1,
|
|
MODE_BROADCAST, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_LengthNotMultipleOfFour(void)
|
|
{
|
|
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC + 6,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC + 3,
|
|
MODE_BROADCAST, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_TooShortExtensionFieldLength(void)
|
|
{
|
|
/* [Bug 2998] We have to get around the formal specification of
|
|
* the extension field if AUTOKEY is undefined. (At least CLANG
|
|
* issues a warning in this case. It's just a warning, but
|
|
* still...
|
|
*/
|
|
uint32_t * pe = testpkt.p.exten + 7;
|
|
|
|
/* The lower 16-bits are the length of the extension field.
|
|
* This lengths must be multiples of 4 bytes, which gives
|
|
* a minimum of 4 byte extension field length.
|
|
*/
|
|
*pe = htonl(3); /* 3 bytes is too short. */
|
|
|
|
/* We send in a pkt_len of header size + 4 byte extension
|
|
* header + 24 byte MAC, this prevents the length error to
|
|
* be caught at an earlier stage
|
|
*/
|
|
int pkt_len = LEN_PKT_NOMAC + 4 + 24;
|
|
|
|
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
|
|
process_pkt(&testpkt.p, &testsock, pkt_len,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_UnauthenticatedPacketReject(void)
|
|
{
|
|
/* Activate authentication option */
|
|
ActivateOption("-a", "123");
|
|
TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
int pkt_len = LEN_PKT_NOMAC;
|
|
|
|
/* We demand authentication, but no MAC header is present. */
|
|
TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
|
|
process_pkt(&testpkt.p, &testsock, pkt_len,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_CryptoNAKPacketReject(void)
|
|
{
|
|
/* Activate authentication option */
|
|
ActivateOption("-a", "123");
|
|
TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
int pkt_len = LEN_PKT_NOMAC + 4; /* + 4 byte MAC = Crypto-NAK */
|
|
|
|
TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
|
|
process_pkt(&testpkt.p, &testsock, pkt_len,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_AuthenticatedPacketInvalid(void)
|
|
{
|
|
/* Activate authentication option */
|
|
PrepareAuthenticationTestMD5(50, 9, "123456789");
|
|
TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
/* Prepare the packet. */
|
|
int pkt_len = LEN_PKT_NOMAC;
|
|
|
|
testpkt.p.exten[0] = htonl(50);
|
|
int mac_len = make_mac(&testpkt.p, pkt_len,
|
|
MAX_MD5_LEN - KEY_MAC_LEN, key_ptr,
|
|
&testpkt.p.exten[1]);
|
|
|
|
pkt_len += 4 + mac_len;
|
|
|
|
/* Now, alter the MAC so it becomes invalid. */
|
|
testpkt.p.exten[1] += 1;
|
|
|
|
TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
|
|
process_pkt(&testpkt.p, &testsock, pkt_len,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_AuthenticatedPacketUnknownKey(void)
|
|
{
|
|
/* Activate authentication option */
|
|
PrepareAuthenticationTestMD5(30, 9, "123456789");
|
|
TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
/* Prepare the packet. Note that the Key-ID expected is 30, but
|
|
* the packet has a key id of 50.
|
|
*/
|
|
int pkt_len = LEN_PKT_NOMAC;
|
|
|
|
testpkt.p.exten[0] = htonl(50);
|
|
int mac_len = make_mac(&testpkt.p, pkt_len,
|
|
MAX_MD5_LEN - KEY_MAC_LEN, key_ptr,
|
|
&testpkt.p.exten[1]);
|
|
pkt_len += KEY_MAC_LEN + mac_len;
|
|
|
|
TEST_ASSERT_EQUAL(SERVER_AUTH_FAIL,
|
|
process_pkt(&testpkt.p, &testsock, pkt_len,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_ServerVersionTooOld(void)
|
|
{
|
|
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
|
|
NTP_OLDVERSION - 1,
|
|
MODE_CLIENT);
|
|
TEST_ASSERT_TRUE(PKT_VERSION(testpkt.p.li_vn_mode) < NTP_OLDVERSION);
|
|
|
|
int pkt_len = LEN_PKT_NOMAC;
|
|
|
|
TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
|
|
process_pkt(&testpkt.p, &testsock, pkt_len,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_ServerVersionTooNew(void)
|
|
{
|
|
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
|
|
NTP_VERSION + 1,
|
|
MODE_CLIENT);
|
|
TEST_ASSERT_TRUE(PKT_VERSION(testpkt.p.li_vn_mode) > NTP_VERSION);
|
|
|
|
int pkt_len = LEN_PKT_NOMAC;
|
|
|
|
TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
|
|
process_pkt(&testpkt.p, &testsock, pkt_len,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_NonWantedMode(void)
|
|
{
|
|
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
|
|
NTP_VERSION,
|
|
MODE_CLIENT);
|
|
|
|
/* The packet has a mode of MODE_CLIENT, but process_pkt expects
|
|
* MODE_SERVER
|
|
*/
|
|
TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
/* Tests bug 1597 */
|
|
void
|
|
test_KoDRate(void)
|
|
{
|
|
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
testpkt.p.stratum = STRATUM_PKT_UNSPEC;
|
|
memcpy(&testpkt.p.refid, "RATE", 4);
|
|
|
|
TEST_ASSERT_EQUAL(KOD_RATE,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_KoDDeny(void)
|
|
{
|
|
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
testpkt.p.stratum = STRATUM_PKT_UNSPEC;
|
|
memcpy(&testpkt.p.refid, "DENY", 4);
|
|
|
|
TEST_ASSERT_EQUAL(KOD_DEMOBILIZE,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_RejectUnsyncedServer(void)
|
|
{
|
|
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOTINSYNC,
|
|
NTP_VERSION,
|
|
MODE_SERVER);
|
|
|
|
TEST_ASSERT_EQUAL(SERVER_UNUSEABLE,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_RejectWrongResponseServerMode(void)
|
|
{
|
|
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
l_fp tmp;
|
|
tmp.l_ui = 1000UL;
|
|
tmp.l_uf = 0UL;
|
|
HTONL_FP(&tmp, &testpkt.p.org);
|
|
|
|
tmp.l_ui = 2000UL;
|
|
tmp.l_uf = 0UL;
|
|
HTONL_FP(&tmp, &testspkt.p.xmt);
|
|
|
|
TEST_ASSERT_EQUAL(PACKET_UNUSEABLE,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_AcceptNoSentPacketBroadcastMode(void)
|
|
{
|
|
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
testpkt.p.li_vn_mode = PKT_LI_VN_MODE(LEAP_NOWARNING,
|
|
NTP_VERSION,
|
|
MODE_BROADCAST);
|
|
|
|
TEST_ASSERT_EQUAL(LEN_PKT_NOMAC,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
|
|
MODE_BROADCAST, NULL, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_CorrectUnauthenticatedPacket(void)
|
|
{
|
|
TEST_ASSERT_FALSE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
TEST_ASSERT_EQUAL(LEN_PKT_NOMAC,
|
|
process_pkt(&testpkt.p, &testsock, LEN_PKT_NOMAC,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_CorrectAuthenticatedPacketMD5(void)
|
|
{
|
|
PrepareAuthenticationTestMD5(10, 15, "123456789abcdef");
|
|
TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
int pkt_len = LEN_PKT_NOMAC;
|
|
|
|
/* Prepare the packet. */
|
|
testpkt.p.exten[0] = htonl(10);
|
|
int mac_len = make_mac(&testpkt.p, pkt_len,
|
|
MAX_MD5_LEN - KEY_MAC_LEN, key_ptr,
|
|
&testpkt.p.exten[1]);
|
|
|
|
pkt_len += KEY_MAC_LEN + mac_len;
|
|
|
|
TEST_ASSERT_EQUAL(pkt_len,
|
|
process_pkt(&testpkt.p, &testsock, pkt_len,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_CorrectAuthenticatedPacketSHA1(void)
|
|
{
|
|
PrepareAuthenticationTest(20, 15, "SHA1", "abcdefghijklmno");
|
|
TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
int pkt_len = LEN_PKT_NOMAC;
|
|
|
|
/* Prepare the packet. */
|
|
testpkt.p.exten[0] = htonl(20);
|
|
int mac_len = make_mac(&testpkt.p, pkt_len,
|
|
MAX_MDG_LEN, key_ptr,
|
|
&testpkt.p.exten[1]);
|
|
|
|
pkt_len += KEY_MAC_LEN + mac_len;
|
|
|
|
TEST_ASSERT_EQUAL(pkt_len,
|
|
process_pkt(&testpkt.p, &testsock, pkt_len,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
}
|
|
|
|
|
|
void
|
|
test_CorrectAuthenticatedPacketCMAC(void)
|
|
{
|
|
#if defined(OPENSSL) && defined(ENABLE_CMAC)
|
|
|
|
PrepareAuthenticationTest(30, CMAC_LENGTH, CMAC, "abcdefghijklmnop");
|
|
TEST_ASSERT_TRUE(ENABLED_OPT(AUTHENTICATION));
|
|
|
|
int pkt_len = LEN_PKT_NOMAC;
|
|
|
|
/* Prepare the packet. */
|
|
testpkt.p.exten[0] = htonl(30);
|
|
int mac_len = make_mac(&testpkt.p, pkt_len,
|
|
MAX_MAC_LEN, key_ptr,
|
|
&testpkt.p.exten[1]);
|
|
|
|
pkt_len += 4 + mac_len;
|
|
|
|
TEST_ASSERT_EQUAL(pkt_len,
|
|
process_pkt(&testpkt.p, &testsock, pkt_len,
|
|
MODE_SERVER, &testspkt.p, "UnitTest"));
|
|
|
|
#else
|
|
|
|
TEST_IGNORE_MESSAGE("OpenSSL CMAC not used, skipping...");
|
|
|
|
#endif /* OPENSSL */
|
|
}
|
|
|