HardenedBSD/tests/sys/net/routing/test_routing_l3.py
Alexander V. Chernikov badcb3fd57 routing: fix panic when adding an interface route to the p2p interface
without and inet/inet6 addresses attached.

MFC after:      3 days
2023-03-29 20:28:24 +00:00

121 lines
4.6 KiB
Python
Executable File

import ipaddress
import socket
import pytest
from atf_python.sys.net.rtsock import RtConst
from atf_python.sys.net.rtsock import Rtsock
from atf_python.sys.net.rtsock import RtsockRtMessage
from atf_python.sys.net.rtsock import SaHelper
from atf_python.sys.net.tools import ToolsHelper
from atf_python.sys.net.vnet import SingleVnetTestTemplate
from atf_python.sys.net.vnet import VnetTestTemplate
class TestIfOps(VnetTestTemplate):
TOPOLOGY = {
"vnet1": {"ifaces": ["if1", "if2"]},
"if1": {"prefixes4": [], "prefixes6": []},
"if2": {"prefixes4": [], "prefixes6": []},
}
@pytest.mark.parametrize("family", ["inet", "inet6"])
@pytest.mark.require_user("root")
def test_change_prefix_route(self, family):
"""Tests that prefix route changes to the new one upon addr deletion"""
vnet = self.vnet_map["vnet1"]
first_iface = vnet.iface_alias_map["if1"]
second_iface = vnet.iface_alias_map["if2"]
if family == "inet":
first_addr = ipaddress.ip_interface("192.0.2.1/24")
second_addr = ipaddress.ip_interface("192.0.2.2/24")
else:
first_addr = ipaddress.ip_interface("2001:db8::1/64")
second_addr = ipaddress.ip_interface("2001:db8::2/64")
first_iface.setup_addr(str(first_addr))
second_iface.setup_addr(str(second_addr))
# At this time prefix should be pointing to the first interface
routes = ToolsHelper.get_routes(family)
px = [r for r in routes if r["destination"] == str(first_addr.network)][0]
assert px["interface-name"] == first_iface.name
# Now delete address from the first interface and verify switchover
first_iface.delete_addr(first_addr.ip)
routes = ToolsHelper.get_routes(family)
px = [r for r in routes if r["destination"] == str(first_addr.network)][0]
assert px["interface-name"] == second_iface.name
@pytest.mark.parametrize(
"family",
[
"inet",
pytest.param("inet6", marks=pytest.mark.xfail(reason="currently fails")),
],
)
@pytest.mark.require_user("root")
def test_change_prefix_route_same_iface(self, family):
"""Tests that prefix route changes to the new ifa upon addr deletion"""
vnet = self.vnet_map["vnet1"]
first_iface = vnet.iface_alias_map["if1"]
if family == "inet":
first_addr = ipaddress.ip_interface("192.0.2.1/24")
second_addr = ipaddress.ip_interface("192.0.2.2/24")
else:
first_addr = ipaddress.ip_interface("2001:db8::1/64")
second_addr = ipaddress.ip_interface("2001:db8::2/64")
first_iface.setup_addr(str(first_addr))
first_iface.setup_addr(str(second_addr))
# At this time prefix should be pointing to the first interface
routes = ToolsHelper.get_routes(family)
px = [r for r in routes if r["destination"] == str(first_addr.network)][0]
assert px["interface-name"] == first_iface.name
# Now delete address from the first interface and verify switchover
first_iface.delete_addr(str(first_addr.ip))
routes = ToolsHelper.get_routes(family)
px = [r for r in routes if r["destination"] == str(first_addr.network)][0]
nhop_kidx = px["nhop"]
assert px["interface-name"] == first_iface.name
nhops = ToolsHelper.get_nhops(family)
nh = [nh for nh in nhops if nh["index"] == nhop_kidx][0]
assert nh["ifa"] == str(second_addr.ip)
class TestRouteCornerCase1(SingleVnetTestTemplate):
@pytest.mark.parametrize("family", ["inet", "inet6"])
@pytest.mark.require_user("root")
def test_add_direct_route_p2p_wo_ifa(self, family):
tun_ifname = ToolsHelper.get_output("/sbin/ifconfig tun create").rstrip()
tun_ifindex = socket.if_nametoindex(tun_ifname)
assert tun_ifindex > 0
rtsock = Rtsock()
if family == "inet":
prefix = "172.16.0.0/12"
else:
prefix = "2a02:6b8::/64"
IFT_ETHER = 0x06
gw_link = SaHelper.link_sa(ifindex=tun_ifindex, iftype=IFT_ETHER)
msg = rtsock.new_rtm_add(prefix, gw_link)
msg.add_link_attr(RtConst.RTA_IFP, tun_ifindex)
rtsock.write_message(msg)
data = rtsock.read_data(msg.rtm_seq)
msg_in = RtsockRtMessage.from_bytes(data)
msg_in.print_in_message()
desired_sa = {
RtConst.RTA_DST: msg.get_sa(RtConst.RTA_DST),
RtConst.RTA_NETMASK: msg.get_sa(RtConst.RTA_NETMASK),
}
msg_in.verify(msg.rtm_type, desired_sa)